RFE: remove unused actx parameter from audit_rule_match

linux-audit / audit-kernel

GitHub mirror of the Linux Kernel's audit repository

https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit.git

Other

137 stars 36 forks source link

RFE: remove unused actx parameter from audit_rule_match #107

Closed rgbriggs closed 5 years ago

rgbriggs commented 5 years ago

The audit_rule_match() struct audit_context *actx parameter is not used by any in-tree consumers (selinux, apparmour, integrity, smack).

The audit context is an internal audit structure that should only be accessed by audit accessor functions. It was part of commit 03d37d25e0f9 ("LSM/Audit: Introduce > generic Audit LSM hooks") but appears to have never been used.

It should be removed. See (brief) discussion: https://www.redhat.com/archives/linux-audit/2019-January/msg00130.html

rgbriggs commented 5 years ago

Post v1 patch to linux-audit, lsm, lkml: https://www.redhat.com/archives/linux-audit/2019-January/msg00134.html https://lkml.org/lkml/2019/1/31/690

pcmoore commented 5 years ago

@rgbriggs assigning to you for obvious reasons, feel free to object.

rgbriggs commented 5 years ago

Staged upstream in audit/next v5.0-rc1: 90462a5bd30c ("audit: remove unused actx param from audit_rule_match")