search

linux-audit / audit-testsuite

A simple, self-contained regression test suite for the Linux Kernel's audit subsystem
GNU General Public License v2.0
21 stars 25 forks source link

tests: update rules to select correct arch #80

Closed rgbriggs closed 5 years ago

rgbriggs commented 5 years ago

Several tests have embedded references to 64-bit architecture rules when they may be run on 32-bit architecture machines. Convert them from "-F arch=b64" to "-F arch=b$ENV{MODE}" or add the arch field where it is missing entirely.

Please see github issue https://github.com/linux-audit/audit-testsuite/issues/78

Signed-off-by: Richard Guy Briggs rgb@redhat.com

pcmoore commented 5 years ago

It would be good to fix the PR style so we get a clean Travis run.

pcmoore commented 5 years ago

Other than the Travis/style issues, this looks reasonable.

rgbriggs commented 5 years ago

On 2019-01-14 11:51, Paul Moore wrote:

It would be good to fix the PR style so we get a clean Travis run.

Is that as simple as running: "./tools/check-syntax -f"?

I thought I saw a previous commit reverted due to a reformat breaking travis. Is there a different repo for travis versions of astyle and perltidy?

pcmoore commented 5 years ago

Is that as simple as running: "./tools/check-syntax -f"?

It should be, yes.

I thought I saw a previous commit reverted due to a reformat breaking travis.

I suspect you are thinking about commit 7ff3e434bc243e667ebb26a22b64176e662fddec. Evidently different versions of perltidy can generate slightly different output; I believe I saw a similar thing with astyle once, but I can't recall the version (or the affected project) at the moment.

At any rate, as I mentioned in the referenced patch, let's just use Travis as the standard right now. If it becomes a real problem we can revisit the issue.

Is there a different repo for travis versions of astyle and perltidy?

The current Travis config appears to be using the Ubuntu Xenial packages at the moment.

WOnder93 commented 5 years ago

Is there a different repo for travis versions of astyle and perltidy?

The current Travis config appears to be using the Ubuntu Xenial packages at the moment.

Yes, hopefully the difference in behavior won't affect us too often. In case it does, you can always just copy-paste the git diff output from the Travis job log into git apply -.

Let me also mention that you can easily enable Travis on your own fork, so you get the check triggered already when you push the changes there, before opening a pull request. You just need to login to https://travis-ci.org/ with your GitHub account and flip the "on" switch on the repository.

rgbriggs commented 5 years ago

On 2019-01-15 11:24, Ondrej Mosnáček wrote:

Is there a different repo for travis versions of astyle and perltidy?

The current Travis config appears to be using the Ubuntu Xenial packages at the moment.

At this point no RHEL has astyle...

Yes, hopefully the difference in behavior won't affect us too often. In case it does, you can always just copy-paste the git diff output from the Travis job log into git apply -.

Let me also mention that you can easily enable Travis on your own fork, so you get the check triggered already when you push the changes there, before opening a pull request. You just need to login to https://travis-ci.org/ with your GitHub account and flip the "on" switch on the repository.

Ok, this is very helpful. Done. At this point do I need to care about "Environmental Variables" or "Cron Jobs"?

WOnder93 commented 5 years ago

Ok, this is very helpful. Done. At this point do I need to care about "Environmental Variables" or "Cron Jobs"?

No, for this simple setup you don't need to care about those.

rgbriggs commented 5 years ago

Pushed update to be considered for merge upstream.

pcmoore commented 5 years ago

Merged via 6d65bf163eb899166e57050901366c583830ddb7, thanks.