linux-audit / audit-testsuite

A simple, self-contained regression test suite for the Linux Kernel's audit subsystem
GNU General Public License v2.0
21 stars 25 forks source link

BUG: tests/user_msg: update for latest even format #89

Closed The-Mule closed 4 years ago

The-Mule commented 4 years ago

Recently, AUDIT_USER message updated its format, see [1].

[1] https://github.com/linux-audit/audit-userspace/commit/93c13545e3e96e97b8f0e52637662a3f9076cf27

The-Mule commented 4 years ago

Travis issue is caused by different test (lost_reset).

rgbriggs commented 4 years ago

On 2019-12-03 04:54, Ondrej Moris wrote:

Travis issue is caused by different test (lost_reset).

The travis test is a nuisance since its output seems to change. Whether this is with travis updates or with other content added in the middle of a source file affecting following lines is unclear to me. I tried setting travis up locally and failed to find and assemble the bits to do it.

pcmoore commented 4 years ago

Travis issue is caused by different test (lost_reset).

You can always submit a patch to fix those issues too ;)

Regardless, the perltidy formatting issue should now be fixed in d907608ee31d4d7fd969736a4d291c968fef53c8, I'll see if I can get Travis to re-test this PR.

pcmoore commented 4 years ago

The travis test is a nuisance since its output seems to change. Whether this is with travis updates or with other content added in the middle of a source file affecting following lines is unclear to me. I tried setting travis up locally and failed to find and assemble the bits to do it.

Suggestions (other than turning off CI tests) are welcome.

pcmoore commented 4 years ago

@The-Mule does this work for both the old and new userspace tools?

The-Mule commented 4 years ago

Good point, Paul. Actually, no. Let me fix it.

The-Mule commented 4 years ago

Test now works with both old and new version of auditd.

pcmoore commented 4 years ago

Thanks @The-Mule, can I add your sign-off to the patch?

Signed-off-by: Ondrej Moris <omoris@redhat.com>
The-Mule commented 4 years ago

Absolutely, apologies for not adding it.

pcmoore commented 4 years ago

Thanks! Merged via 33a94af2bd2a619d531ac632817c266f06a29b5f.