Add formatters and linters to the CI and fix the fallout

linux-automation / lxa-iobus

Linux Automation IOBus server

https://lxa-iobus.readthedocs.io/en/latest/

Apache License 2.0

3 stars 4 forks source link

Add formatters and linters to the CI and fix the fallout #36

Closed hnez closed 5 months ago

hnez commented 5 months ago

This PR adds black, isort and prettier (auto formatters) and flake8 (python linter), as well as codespell to check for typos and fixes all issues that the various tools brought up.

TODO before merging:

[x] ~~This PR is now based on #34, which already added black and flake8. That PR should be merged first and then this one should be rebased on top of it.~~ This PR is no longer based on #34, because it now uses ruff instead of black + flake8 + isort, which has the benefit of having one tool and not three tools fighting about the question what python code should look like.

hnez commented 5 months ago

I've only noticed that this duplicates work that was already done in #34. I will rebase my work on top of it, make sure that everything works and if so add my approval to that PR so that we can get it merged, because it also addressed a few things that I did not spot.

SmithChart commented 5 months ago

I've only noticed that this duplicates work that was already done in #34. I will rebase my work on top of it, make sure that everything works and if so add my approval to that PR so that we can get it merged, because it also addressed a few things that I did not spot.

Feel free to pick the changes you missed from there and add them to your PR. I don't mind if we drop my PR in favor of yours.

hnez commented 5 months ago

Feel free to pick the changes you missed from there and add them to your PR. I don't mind if we drop my PR in favor of yours.

Nah, that would be rude. I've instead decided to rebase on top of it and push fixups that came out of that into your branch. I guess some would consider that just as rude, so sorry for that ….

Now this PR just adds codespell, isort and prettier.