linux-automation / lxa-iobus

Linux Automation IOBus server

https://lxa-iobus.readthedocs.io/en/latest/

Apache License 2.0

3 stars 4 forks source link

Cleanups, code deduplication, improvements and maintenance #38

Closed hnez closed 5 months ago

hnez commented 5 months ago

Just like the diffuse PR title implies this is a collection of changes that I have accumulated while working on the LXA Optick support, which itself is added in another pull request.

TODO before merging:

[x] This PR is based on #37, which is in turn based on #36, so these PRs should be merged before this one.
[x] Do some more testing of the end product and intermediate steps, to make sure that the changes do not cause any regressions.

SmithChart commented 5 months ago

36 and #37 have been merged. Please rebase and resolve conflicts.

hnez commented 5 months ago

I've rebased on top of recent master and tested this pull request with a couple of LXA Ethernet Muxes (because I did not test those previously). Seems to work fine.

SmithChart commented 5 months ago

In commit "lxa_iobus: node: replace ad-hoc struct parsing with central object_directory":

Previously unpacking and packing structs to send to the node was done
always done ad-hoc, where it was needed.

Sounds like there is one done too much there.

hnez commented 5 months ago

In commit "lxa_iobus: node: replace ad-hoc struct parsing with central object_directory":
Previously unpacking and packing structs to send to the node was done
always done ad-hoc, where it was needed.
Sounds like there is one done too much there.

Good catch, should be fixed.