CI: add a linting step for all of our custom bitbake recipes

linux-automation / meta-lxatac

Build your own LXA TAC images and bundles

MIT License

5 stars 15 forks source link

CI: add a linting step for all of our custom bitbake recipes #114

Open hnez opened 4 months ago

hnez commented 4 months ago

This PR is inspired by #110, which mentions running meta-openembedded's oe-stylize.py on the bitbakes files in meta-lxatac.

Now that I have learned that there is a linter script for bitbake files I want it as a GitHub action.

So here is a pull request to add it.

TODO before merging:

[ ] Make sure the action runs without errors

ejoerns commented 4 months ago

@hnez While I like the idea in general, I have some objections against running this in CI: The script is not too actively maintained (primarily got some PEP8-related fixes over the last years) and is not part of oe-core. I have seen several false positives I had to re-fix manually in some recipes (like when properly using self-defined variables).

Thus I'd say it is a good tool for running manually on your recipe, but I am not sure if we should enforce it in CI automatically.