search

linux-automation / meta-lxatac

Build your own LXA TAC images and bundles
MIT License
5 stars 15 forks source link

meta-lxatac-software: android-tools: backport 10.0.0 from meta-oe #34

Closed hnez closed 1 year ago

hnez commented 1 year ago

The fastboot binary we currently ship only works when manually supplied the USB vendor id of the device we want to flash. This is non-intuitive and newer fastboot just finds the right device automagically.

Backport a newer android-tools from meta-oe master and add meta-selinux which provides libselinux.

I'm not a fan of adding meta-selinux just for libselinux, so if there are any other ideas I am open for it.

The addition of the meta layer also means that bblayer templates in custom meta-lxatac derived BSPs have to be updated in tandem.

hnez commented 1 year ago

Forgot to mention @a3f in the original pull request description. Doing it now because I know he will be happy to see some progress on the fastboot front.

Emantor commented 1 year ago

Why do we need this? Labgrid is perfectly fine with passing in the USB vendor id.

hnez commented 1 year ago

Labgrid may be, but are our users as well? At least I and @a3f were rather confused when fastboot proclaimed that there was no fastbootable device to be found. The UX of the newer fastboot is better in that regard.

jluebbe commented 1 year ago

Why do we need this? Labgrid is perfectly fine with passing in the USB vendor id.

Note that since https://github.com/labgrid-project/labgrid/commit/5516d3629e558760f04d57c054a06f1cb4048422 we no longer pass the vendor ID, so this was broken on the LXA TAC without local patches.

a3f commented 1 year ago

What's the blocker for merging this?

Emantor commented 1 year ago

Passing the usb path still works, so I'm fine with this.