search

linux-automation / meta-lxatac

Build your own LXA TAC images and bundles
MIT License
5 stars 15 forks source link

oe-init-build-env: make script independent of `pwd` #55

Closed userid0x0 closed 10 months ago

userid0x0 commented 10 months ago

Hi, this is only a slight change in the oe-init-build-env that removes the requirement to source the script from meta-lxatac. Thus it works fine with crops/yocto containers:

# Podman
podman run --rm --tty --interactive \
  --userns=keep-id --user $(id -u):$(id -g) \
  --env HOME=/tmp --tmpfs /tmp \
  --volume $(pwd)/meta-lxatac:$(pwd)/meta-lxatac \
  ghcr.io/crops/yocto:debian-10-builder \
  --pokydir $(pwd)/meta-lxatac --target lxatac-core-bundle-base --builddir $(pwd)/meta-lxatac/build
hnez commented 10 months ago

The readlink -f "${DIR}" went missing with the latest change. I've added a commit that re-introduces it and pushed it to your branch. I hope that's okay for you.

I also ran shellcheck on the script (because I don't trust my shell-scripting skills) and fixed warnings regarding unquoted use of variables.

The PR now looks good to me, so I am going to click merge. Thanks for your contribution!

userid0x0 commented 10 months ago

You are correct, I wanted to do a negative test as well. Thanks for your assistance here.