search

linux-automation / meta-lxatac

Build your own LXA TAC images and bundles
MIT License
5 stars 15 forks source link

meta-lxatac-software: labgrid-exporter: more specific usb serial match #67

Closed hnez closed 9 months ago

hnez commented 9 months ago

The less-specific {{sysfs}} match also matches on {{sysfs}}:1.1, {{sysfs}}:1.2, {{sysfs}}:1.3 etc.. This results in labgrid being rightfully confused about udev events for said devices.

Match on the more specific {{sysfs}}:1.0 instead.

A side-effect of this change is that the first port is now exported as lxatac-usb-ports-p1.0 instead of lxatac-usb-ports-p1.

This fixes #66.

Bastian-Krause commented 9 months ago

Looks okay from the configuration side, but it will break a lot of existing place matches. Is it worth it?

jluebbe commented 9 months ago

To keep compatibility, we could just add :1.0 to the "default" match under lxatac-usb-ports-p1.

hnez commented 9 months ago

add :1.0 to the "default" match under lxatac-usb-ports-p1.

That's okay with me. Did that just now.

jluebbe commented 9 months ago

@Bastian-Krause Are you fine with this?