search

linux-can / can-utils

Linux-CAN / SocketCAN user space applications
2.37k stars 708 forks source link

Refactor the help/usage message for canplayer #522

Closed delta512 closed 4 months ago

delta512 commented 4 months ago

Dear maintainers,

as a side effect of PR #521 development, we noticed that the canplayer utility returns with an error value, even when asked for the help message explicitly. We thought it might be nicer to limit the above behavior only to unknown options.

We also changed the option from a question mark -? into an -h, which is more common among CLI tools.

Hope you'll find these nuances sound and do not hesitate to request changes.

Have a great day again!

marckleinebudde commented 4 months ago

Thanks for the contribution. Please add -h to print_usage().

delta512 commented 4 months ago

Thanks for the contribution. Please add -h to print_usage().

Oh, I really missed on this. I amended the previous commit so it's all well packed together.

Hope it looks good know