linux-china / jetbrains-just-plugin

JetBrains Just Command Runner Plugin
https://plugins.jetbrains.com/plugin/18658-just
Apache License 2.0
35 stars 6 forks source link

Icon looks out of place #2

Closed dhruvkb closed 2 years ago

dhruvkb commented 2 years ago

Thanks for the incredible plugin. I just wanted to point out that the icon for the Justfile (the black circle with 2 dots) looks out of place when compared with the other icons.

Screenshot 2022-04-29 at 5 02 36 AM

Can we use some icon from JetBrains' default set of icons? They have a lot of good ones that can meaningfully convey a task runner file. In fact, the icon for a plain file AllIcons.FileTypes.Any_type with a superimposed green run icon AllIcons.Nodes.RunnableMark would look pretty decent.

linux-china commented 2 years ago

Yes, icon in file explore tool window should be 12x12, and I corrected it already.

dhruvkb commented 2 years ago

The icon that you have chosen for Justfile (the circle with two vertically aligned dots) doesn't suit the IDE when using a dark theme. It's very difficult to see as it is, and nearly impossible when that file is selected.

Screenshot 2022-06-09 at 4 10 28 AM
linux-china commented 2 years ago

@dhruvkb could you submit an issue on https://github.com/casey/just for icon art work? :) If not possible, and I will use run icon instead of current just icon in next version.