search

linux-cultist / venv-selector.nvim

Allows selection of python virtual environment from within neovim
MIT License
388 stars 41 forks source link

feat: Add pyenv-virtualenv support #20

Closed IceS2 closed 1 year ago

IceS2 commented 1 year ago

Hello folks!

From the discussion on #18 I decided to try to start the implementation (Thanks @linux-cultist for setting the path). There are a few things missing:

I also wanted to add a way to disable some managers to avoid noise and decided to go with disabling it using an empty string "", not sure there's a better way in Lua (I'm fairly new to the language). (Removed as per suggestion)

Last but not least, I'm really sorry about the indentation mess. My editor uses 2 spaces as default and I was trying to fix it manually but it got messy :rofl: I'd love to know how/what to configure in order to comply with the style (=

closes #18

linux-cultist commented 1 year ago

Thanks for making a PR, I love when people contribute a solution like this. :) If you agree to the changes I suggest, we can merge this tomorrow. The remaining part is adding a line to the README and I can add that if you want to.

And dont worry about indentation... everyone is using slightly different settings and I tend to just format the code according to what im using, just to keep it consistent, after I merge a PR. Its easier than making everyone set up their editors in the exact same way as me. :)

IceS2 commented 1 year ago

Thanks for making a PR, I love when people contribute a solution like this. :) If you agree to the changes I suggest, we can merge this tomorrow. The remaining part is adding a line to the README and I can add that if you want to.

And dont worry about indentation... everyone is using slightly different settings and I tend to just format the code according to what im using, just to keep it consistent, after I merge a PR. Its easier than making everyone set up their editors in the exact same way as me. :)

Alright! I think everything makes sense! Thanks a lot for reviewing it (= I actually enjoy a lot collaborating with this kind of projects. I don't have much experience with it but I've been doing small things here or there o/

I'll work on the changes + the README tomorrow before or after work! (Again if you want to merge it before just feel free to add your commit and merge it)

IceS2 commented 1 year ago

Ok, I managed to find some extra time to do it tonight!

Check it out and see what you think please (=

(Again you'll see that the indentation is all messy but I didn't care about it as you suggested :+1: )

linux-cultist commented 1 year ago

Alright! I think everything makes sense! Thanks a lot for reviewing it (= I actually enjoy a lot collaborating with this kind of projects. I don't have much experience with it but I've been doing small things here or there o/

Yeah I feel the same. Open source can be awesome, and its very rewarding to contribute to something you use yourself like this. Personally Im super happy to see PR's since they often are good and solves a problem or adds a feature I havent thought about myself. :) One person cant think of all the possibilities or usecases, and its nice to work with people in other countries as well.

linux-cultist commented 1 year ago

I will merge this and just add formatting afterwards. :) Huge thanks for your contribution here!