search

linux-cultist / venv-selector.nvim

Allows selection of python virtual environment from within neovim
MIT License
388 stars 41 forks source link

Silence the `Activated` message #23

Closed petobens closed 1 year ago

petobens commented 1 year ago

I use the statusline to indicate whether I have an active enviroment or not. I was wondering whether you could make optional the Activation message in https://github.com/linux-cultist/venv-selector.nvim/blob/479a145f8f4dd854cffd7289f18b8267f82e5cf0/lua/venv-selector/venv.lua#L93

linux-cultist commented 1 year ago

Yes absolutely. I can add it this weekend, but you can also make a PR yourself if you have time before that. Some option that is true by default would probably be easiest to understand for users, and you can set it to false to not get notified.

If you don't have time I will add it on Saturday. :)

petobens commented 1 year ago

Hi @linux-cultist ; I'd probably wait for you to add it since I understood per https://github.com/linux-cultist/venv-selector.nvim/issues/21#issuecomment-1529115354 that you are also going to do some refactoring..

Thanks :)

linux-cultist commented 1 year ago

Yeah I want to, but have been very busy now with a new job and lots of stuff to learn there. But I hope I can do some refactoring and cleanup next weekend. But adding that flag is quick and i will do that today. :)

linux-cultist commented 1 year ago

Ok, I added the option notify_user_on_activate that you can set to false, and the plugin will not say anything on venv activation. :) Closing the issue but you can reopen if you have more feedback on this!

petobens commented 1 year ago

Great thanks!