search

linux-cultist / venv-selector.nvim

Allows selection of python virtual environment from within neovim
MIT License
379 stars 40 forks source link

Bugfix and readability improvement #84

Closed mennohofste closed 6 months ago

mennohofste commented 7 months ago

A combination of small updates I have been testing over the past few days.

This PR includes the removal of set_pythonpath, which has been replaced by hooks #81. No users should be negatively affected.

This is not ready to merge yet. I will use this for a few more days. Any feedback is welcome!

mennohofste commented 7 months ago

I have not encountered any changes in behaviour after using it for a while. I think it is ready for review.

mennohofste commented 7 months ago

I happen to be reading this comment in the nvim-lspconfig repo. https://github.com/neovim/nvim-lspconfig/issues/299#issuecomment-718458638

I think Pylance has not been working outside of VSCode since 2020, so I assume it is safe to remove entirely?

linux-cultist commented 7 months ago

Seems to work fine for me also, did a testrun here and didnt notice anything breaking.

And yes, please remove Pylance when you are at it. :)

Changes look good to me so Im ready to merge it in whenever you feel ready.

mennohofste commented 7 months ago

I rebased to clean up some commits, and I think it can be merged now if everything looks good.

I am still looking at a few small things, but those can be added in another PR.

mennohofste commented 7 months ago

I just noticed that I forgot to update the documentation. Will do that first.

mennohofste commented 7 months ago

Now the docs should also be up-to-date.

linux-cultist commented 6 months ago

Ok thank you. What do you say, we merge this in or do you want to add more changes?

mennohofste commented 6 months ago

I think you can merge it. 👍

linux-cultist commented 6 months ago

Thanks, perfect :)