Feedback: Removed unused/unreachable code

linux-msm / qdl

BSD 3-Clause "New" or "Revised" License

196 stars 76 forks source link

Feedback: Removed unused/unreachable code #2

Closed danielkutik closed 1 month ago

danielkutik commented 5 years ago

Removed two unused defines and a unused value. Further there is some unreachable code that needs to be looked at.

Do not merge, to be discussed.

andersson commented 5 years ago

We should fix the missing unref of the udev objects, instead of just adding a FIXME - preferably as one patch removing the unused code and a separate that fixes the udev handling.

If you update your patch accordingly I would be very happy to merge it!

Thanks, Bjorn