search

linux-nfc / neard

NFC Daemon for Linux
GNU General Public License v2.0
30 stars 11 forks source link

Added UID to the DBUS API #19

Closed vinicius-smartme closed 1 year ago

vinicius-smartme commented 1 year ago

The code modifications are from https://lore.kernel.org/linux-nfc/20210311085020.429987-1-frieder.schrempf@kontron.de/T/

I updated the tag API documentation with the new property. I also updated the README.

krzk commented 1 year ago

Thanks for the change.

I don't think you preserved the authorship of original commit/patch. Also, some unrelated parts got inside the commit.

krzk commented 1 year ago

Does not compile, authorship of original patch lost (please retain it).

vinicius-smartme commented 1 year ago

Should I use the git am with a patch file from the link on a commit and then do my modifications?

krzk commented 1 year ago

Yes, with build issues probably fixed within that commit. Unrelated changes should be made a separate commits.