search

linux-nvme / nvme-cli

NVMe management command line interface.
https://nvmexpress.org
GNU General Public License v2.0
1.44k stars 648 forks source link

solidigm: Eliminate <linux/limits.h> #2334

Closed bsdimp closed 3 months ago

bsdimp commented 3 months ago

ARG_MAX is defined in , per POSIX, but it's defined to be a variable in glibc. Instead, get rid of it entirely by using asprintf to construct the commands. This prevents us from trying a partially constructed command that might do something unintentional. For solidigm-market-log.c, there's no constants needed from <linux/limits.h>. With this we can delete it both places.

igaw commented 3 months ago

rebase and merge conflict resolved

igaw commented 3 months ago

Thanks!