search

linux-nvme / nvme-cli

NVMe management command line interface.
https://nvmexpress.org
GNU General Public License v2.0
1.44k stars 647 forks source link

plugins/solidigm: Added log pages to vs-internal-logs #2349

Closed lgdacunh closed 3 months ago

lgdacunh commented 3 months ago

Added some Identify pages, and some standard log, and some VU logs. Created abstract data type with common fields for internal logs. Better string buffer overflow avoidance.

igaw commented 3 months ago

Thanks!

As there other places which use the fixed size buffer for string formatting, there was no point in asking to update this update. Maybe update the all the places in one go next time, if you agree with my idea.

lgdacunh commented 3 months ago

Thanks!

As there other places which use the fixed size buffer for string formatting, there was no point in asking to update this update. Maybe update the all the places in one go next time, if you agree with my idea.

I agree asprintf() with cleanup is less error prone. I will figure out a strategy for this change.