search

linux-nvme / nvme-cli

NVMe management command line interface.
https://nvmexpress.org
GNU General Public License v2.0
1.46k stars 654 forks source link

nvme-print-stdout: print MEM bit of CTRATT field #2357

Closed francispravin5 closed 4 months ago

francispravin5 commented 4 months ago

Print MDTS and Size Limits Exclude Metadata(MEM) bit of CTRATT field which added in TP-4099.

igaw commented 4 months ago

Code looks fine, though a few questions. Is the TP already released? I got the impression it is still in the 30 days review period.

Second, the TP defines a few more bits, wouldn't it make sense to add them as well.

And shouldn't we also update the json output as well?

francispravin5 commented 4 months ago
  1. TP-4099 (MDTS Enhancement) is already ratified.
  2. There is only one bit field (MEM) is added as part of this TP (Fig-275).
  3. As per the existing implementation, the entire value of ctratt filed is updated in json, not bit by bit.

Thanks!

igaw commented 4 months ago

Thanks for the clarification. I must have looked at the wrong document.

json: ah okay, I didn't check if we decode the field or not. Maybe we should?

igaw commented 4 months ago

Thanks!