linux-nvme / nvme-cli

NVMe management command line interface.
https://nvmexpress.org
GNU General Public License v2.0
1.41k stars 637 forks source link

plugins/ocp : Fixed the OCP Telemetry String Log Page (LID:C9h) fix #2373

Closed VigneshwaranSaravana closed 6 days ago

VigneshwaranSaravana commented 3 weeks ago

This PR will take care the below failures for "telemetry-string-log" Resolved the json printing issue Changed the Statistic Identifier, Event String, Vendor Unique, ASCII table offset and size calculation

Signed-off-by: Vigneshwaran Saravanan/Vigneshwaran Saravanan s.vignesh@samsung.com

Reviewed-by: Karthik Balan karthik.b82@samsung.com, Reviewed-by: Arunpandian J arun.j@samsung.com, Reviewed-by: Jayakanthan Rajendran jaya.ganthan@samsung.com

igaw commented 2 weeks ago

Please address the issues reported by checkpatch

WARNING: Missing commit description - Add an appropriate one
Error: WARNING: Missing commit description - Add an appropriate one

WARNING: Unexpected content after email: 'Karthik Balan <karthik.b82@samsung.com>, Arunpandian J', should be: 'Karthik Balan <karthik.b82@samsung.com> (, Arunpandian J)'
#8:
Reviewed-by: Karthik Balan <karthik.b82@samsung.com>, Arunpandian J
Error: WARNING: Unexpected content after email: 'Karthik Balan <karthik.b82@samsung.com>, Arunpandian J', should be: 'Karthik Balan <karthik.b82@samsung.com> (, Arunpandian J)'

ERROR: space required before the open brace '{'
#61: FILE: plugins/ocp/ocp-nvme.c:2900:
+ if (log_data->sitsz != 0){
Error: ERROR: space required before the open brace '{'

[...]
VigneshwaranSaravana commented 2 weeks ago

@igaw - I have resolved all the coding guidelines issue. Even I have updated the commit description but still patch run failed due to WARNING: Missing commit description - Add an appropriate one. Could you please check

igaw commented 2 weeks ago

I have the same feedback as in the other PR (https://github.com/linux-nvme/nvme-cli/pull/2374#issuecomment-2194381370)

VigneshwaranSaravana commented 1 week ago

@igaw - Incorporated the review comment. Please check

igaw commented 1 week ago

I don't see any changes here. Still the version from last week.

igaw commented 1 week ago

@arthurshau as we are almost there with this PR, could you have a look?

arthurshau commented 1 week ago

Logic LGTM

igaw commented 6 days ago

Updated the commit message myself.

igaw commented 6 days ago

Thanks.