Closed VigneshwaranSaravana closed 6 days ago
Please address the issues reported by checkpatch
WARNING: Missing commit description - Add an appropriate one
Error: WARNING: Missing commit description - Add an appropriate one
WARNING: Unexpected content after email: 'Karthik Balan <karthik.b82@samsung.com>, Arunpandian J', should be: 'Karthik Balan <karthik.b82@samsung.com> (, Arunpandian J)'
#8:
Reviewed-by: Karthik Balan <karthik.b82@samsung.com>, Arunpandian J
Error: WARNING: Unexpected content after email: 'Karthik Balan <karthik.b82@samsung.com>, Arunpandian J', should be: 'Karthik Balan <karthik.b82@samsung.com> (, Arunpandian J)'
ERROR: space required before the open brace '{'
#61: FILE: plugins/ocp/ocp-nvme.c:2900:
+ if (log_data->sitsz != 0){
Error: ERROR: space required before the open brace '{'
[...]
@igaw - I have resolved all the coding guidelines issue. Even I have updated the commit description but still patch run failed due to WARNING: Missing commit description - Add an appropriate one. Could you please check
I have the same feedback as in the other PR (https://github.com/linux-nvme/nvme-cli/pull/2374#issuecomment-2194381370)
@igaw - Incorporated the review comment. Please check
I don't see any changes here. Still the version from last week.
@arthurshau as we are almost there with this PR, could you have a look?
Logic LGTM
Updated the commit message myself.
Thanks.
This PR will take care the below failures for "telemetry-string-log" Resolved the json printing issue Changed the Statistic Identifier, Event String, Vendor Unique, ASCII table offset and size calculation
Signed-off-by: Vigneshwaran Saravanan/Vigneshwaran Saravanan s.vignesh@samsung.com
Reviewed-by: Karthik Balan karthik.b82@samsung.com, Reviewed-by: Arunpandian J arun.j@samsung.com, Reviewed-by: Jayakanthan Rajendran jaya.ganthan@samsung.com