I suggest you split the changes into several PRs. There different things which are updated which makes it a bit confusing to review.
So let me give some feedback some quick feedback:
the first one is fine.
second one, there are plenty of more places outside of the print code which use enum nvme_print_flags, e.g. in nvme.c. So these users of enum nvme_print_flags need to be updated/reviewed as well. Please as new patch :)
The reformatting patches: I know you like to get checkpatch clean everything. But it's just a tool which give suggestion IMO. That means we don't have to be 100% clean. Personally I care a lot more about consistency within a file or function. That means if a certain style is used and even if checkpatch complains I leave it. Having different indention strategy within a function looks ugly to me, e.g.
Anyway these patches should be a separate PR.
the fahrenheit command line option. I think we should not introduce a command line option for this and instead just use the locale information.
As already merged split the first patch. Update the PR patch for the second patch only. The reformatting patches and the fahrenheit command line option I will do change and consider separately. Thank you.
I suggest you split the changes into several PRs. There different things which are updated which makes it a bit confusing to review.
So let me give some feedback some quick feedback:
enum nvme_print_flags
, e.g. in nvme.c. So these users ofenum nvme_print_flags
need to be updated/reviewed as well. Please as new patch :)