Closed xyzhang-up closed 3 months ago
I have dealt with the errors detected by the workflow as much as possible.
there are two alerts that I think do not need to be processed:
#define CMD_INC_FILE plugins/dapustor/dapustor-nvme
Macros does not need to be enclosed in parentheses here.
ENTRY("smart-log-add", "Retrieve DapuStor SMART Log, show it", dapustor_additional_smart_log)
I think it is better to keep it on one line.
Besides, where should I update the maintainer information of the new files? Thank you.
checkpatch complaints need to be taken with a grain of salt. I agree with you, the long line looks nicer. Anyway, this looks in good shape. Please consider to update the tab completion and provide documentation to this new plugin. I go ahead and merge it as it is. We can improve it in the tree. Thanks!
Add the DapuStor plugin to support the retrieval and display of the Vendor Specific SMART logs: Additional SMART log page (0xCA) Extended Additional SMART log page (0xCB)
After the command
nvme dapustor smart-log-add
is executed, the information in the following format will be returned: