search

linux-nvme / nvme-cli

NVMe management command line interface.
https://nvmexpress.org
GNU General Public License v2.0
1.47k stars 655 forks source link

fixing CNS 11h to generate identify per allocated namespace. #2473

Closed HaroPanosyan closed 1 month ago

HaroPanosyan commented 2 months ago

Fixing generation of CNS 11h identify namespace data structure generation for each allocated namespace instead of attached namespace.

HaroPanosyan commented 2 months ago

Fixing generation of CNS 11h identify namespace data structure generation for each allocated namespace instead of attached namespace.

Please ignore this mess. It would be nice if I can remove this Pull request and then will create new one clean.

igaw commented 2 months ago

Deleting pull request is not so easy. Only the plattform admins can do this. But it's not that bad you can fix your branch locally with all sort of git operation (rebasing, squashing etc) and just force push it to this branch. This will fix it.

HaroPanosyan commented 2 months ago

Deleting pull request is not so easy. Only the plattform admins can do this. But it's not that bad you can fix your branch locally with all sort of git operation (rebasing, squashing etc) and just force push it to this branch. This will fix it.

Thanks, will do, I have a good help here.

HaroPanosyan commented 2 months ago

Cleaned up the mess with 3 commits. Now only one clean commit to be reviewed.

igaw commented 2 months ago

Looks good. Just your Signed-off-by tag is missing. I can add it myself if you are okay with it.

HaroPanosyan commented 2 months ago

Looks good. Just your Signed-off-by tag is missing. I can add it myself if you are okay with it.

Thanks for your help... I rebased and added Signed-off-by tag.

igaw commented 1 month ago

Thanks!