linux-nvme / nvme-cli

NVMe management command line interface.
https://nvmexpress.org
GNU General Public License v2.0
1.49k stars 660 forks source link

ocp: Fixes for OCP 2.5 Telemetry DA1 FIFO Event Parsing #2508

Closed jeff-lien-wdc closed 1 month ago

jeff-lien-wdc commented 2 months ago

This commit fixes several issues related to parsing the Telemetry DA 1 and 2 Event FIFO's.

Fixes parsing of VU Event Data. Added checking for VU data. Removed the vu_event_identifier field from the debug event class structs since it's not guaranteed to be there. Added nvme_ocp_common_dbg_evt_class_vu_data to be used to access the VU data.

Added checking for NULL pointers

Added a check for the end of the Event FIFO entries that will
break from the while loop when detected.
igaw commented 1 month ago

Could you squash the commits together when this change is ready to be merged? Thanks.

jeff-lien-wdc commented 1 month ago

Could you squash the commits together when this change is ready to be merged? Thanks.

@igaw Yes, I will do that. Just wrapping up some fixes and changes from Brandon's review comments. Those should be done today.

igaw commented 1 month ago

I forgot to add @arthurshau for a review.

arthurshau commented 1 month ago

LGTM

igaw commented 1 month ago

Thanks!