nvme: Support show-regs for nvmeof

linux-nvme / nvme-cli

NVMe management command line interface.

https://nvmexpress.org

GNU General Public License v2.0

1.49k stars 660 forks source link

nvme: Support show-regs for nvmeof #2521

Closed hmi-jeon closed 1 month ago

hmi-jeon commented 1 month ago

Get properties only at offsets that support nvme fabric registers. Since crto was not found in the nvmeof spec, it is removed. Also, NSSR is only optional register. If the device is not supported by the optional register, the error is ignored.

Reviewed-by: Steven Seungcheol sc108.lee@samsung.com Signed-off-by: Minsik Jeon hmi.jeon@samsung.com

igaw commented 1 month ago

Thanks!

We should though rethink this part of the code. Really messy how it currently is.