linux-nvme / nvme-cli

NVMe management command line interface.
https://nvmexpress.org
GNU General Public License v2.0
1.49k stars 659 forks source link

ocp: fix TCG configuration log endian #2550

Closed ikegami-t closed 3 weeks ago

ikegami-t commented 3 weeks ago

Fix the entry data fields to little endian format. Basically print functions convert the fields data to cpu format. But still some errors then fixed the print json functions also.

igaw commented 3 weeks ago

Haven't checked the spec, can't really find the right section in there. So I defer the review to @arthurshau :)

arthurshau commented 3 weeks ago

LGTM

ikegami-t commented 3 weeks ago

Thanks for your reviewing and merging! FYI: Just attached the documentations and the links are also below.

OCP v1.0.3: nvme-cloud-ssd-specification-v1-0-3-pdf.pdf

https://www.opencompute.org/documents/nvme-cloud-ssd-specification-v1-0-3-pdf

OCP v2.0: Datacenter NVMe SSD Specification v2.0r21.pdf

https://www.opencompute.org/documents/datacenter-nvme-ssd-specification-v2-0r21-pdf

OCP v2.5: datacenter-nvme-ssd-specification-v2-5-pdf.pdf

https://www.opencompute.org/documents/datacenter-nvme-ssd-specification-v2-5-pdf