search

linux-nvme / nvme-cli

NVMe management command line interface.
https://nvmexpress.org
GNU General Public License v2.0
1.49k stars 659 forks source link

nvme: change NVME_ARGS -v and -o options ordering to back #2556

Closed ikegami-t closed 1 week ago

ikegami-t commented 2 weeks ago

This reverts the short options -o and -v changes as before. Before the short option -o used for admin-passthru command opcode option. But currently changed the short option -o for output-format option.

Fixes: 0ded9387b ("nvme: Change short option -o and -v duplicated to upper case")

igaw commented 2 weeks ago

I am not happy to change the command line options again. Though I haven't looked into closely yet.

ikegami-t commented 1 week ago

Yes I know you mentioned this before by the PR comments comment https://github.com/linux-nvme/nvme-cli/pull/2285#issuecomment-2166109178 then the short options including -o were not changed. But actually the -o option issue has just been reported again so I thought to try to fix the options again. But still should we keep the short options -o and -v? Note: Currently the script failed by using -o option is also going to be changed to use --opcode instead as same with the linux-nvme mailing list mentioned by the PR comment https://github.com/linux-nvme/nvme-cli/pull/2285#issuecomment-2074877250. Thank you.

igaw commented 1 week ago

My point is that we already broke the short hand options for the -o and -v users. Now all commands understand -o and -v as --output-format and --verbose (I do like this). Changing the old users again is just making even more a mess. If there are scripts out there which have a workaround by checking the version of nvme-cli than they have to update again to check for ranges. We broke them, breaking them again is not really helping.

Thus I'd like to keep them as we have them now. For scripting I recommend to use the long options.

ikegami-t commented 1 week ago

Thank you so much for your explanation. Understood so let me close the PR.