search

linux-nvme / nvme-cli

NVMe management command line interface.
https://nvmexpress.org
GNU General Public License v2.0
1.49k stars 660 forks source link

ocp uuidx #2582

Open YUEyuan310 opened 4 days ago

YUEyuan310 commented 4 days ago

Why do some OCP commands specify UUID, while others do not？

ocp_get_uuid_index(dev, &uuid_index);？

For example： The command fw activate history specifies uuidx The command hardware-component-log doesn't specify uuidx.

YUEyuan310 commented 4 days ago

Should the uuid function be completed?

igaw commented 4 days ago

I think the question is for you guys, @ikegami-t @sc108-lee @arthurshau

ikegami-t commented 4 days ago

Because it is required by the OCP specification. For example the error injection set features required it as below by the OCP version 2.6. ocp-error-inject-set But it was not required by the OCP version 1.0.3 as below. ocp-error-inject-set-v1 0 3

ikegami-t commented 4 days ago

Sorry the answer above was not correct. The UUID is described by the set features commands but as @YUEyuan310 mentioned it is required for the get log page command also as below so needed to fix OCP get log page commands not set the uuid index to use it. uuid

YUEyuan310 commented 3 days ago

Sorry the answer above was not correct. The UUID is described by the set features commands but as @YUEyuan310 mentioned it is required for the get log page command also as below so needed to fix OCP get log page commands not set the uuid index to use it. uuid

I share your opinion that the get-log command in OCP needs to have its uuidx functionality completed.

sc108-lee commented 3 days ago

Yes I agree, we should add into the OCP get log commands.

ikegami-t commented 1 day ago

Could you please review the PR #2583 to fix the HWCOMP log command to set the UUID index? If okay I am thinking to fix other OCP log page commands not set the UUID index also.