search

linux-nvme / nvme-cli

NVMe management command line interface.
https://nvmexpress.org
GNU General Public License v2.0
1.45k stars 650 forks source link

Script to Check a Patch Satisfying min Coding Guidelines or Not #856

Closed ganaidu707 closed 3 years ago

ganaidu707 commented 3 years ago

Could you tell us like what are the guidelines does nvme-cli follows?

We can have a script to check whether the given patch following certain guidelines.

e.g: 1. 80 Character per line e.g: 2. If any white space characters check etc..

or it is already existed?

keithbusch commented 3 years ago

We've adopted the Linux kernel coding style, though they've been very loosely applied to the vendor extensions... I think the kernel's checkpatch.pl utility should work here.

ganaidu707 commented 3 years ago

Yes that works, but not able to find that checkpatch.pl utility here, can we pull it to this code base, so that before commit, we can verify coding guidelines.