search

linux-nvme / nvme-stas

NVMe STorage Appliance Services
Apache License 2.0
24 stars 13 forks source link

iputil: pack and unpack using native byte ordering #406

Closed ogayot closed 11 months ago

ogayot commented 11 months ago

On big-endian architectures (such as s390x), tests defined in test-iputil.py would hang:

 596s test_get_interface (test-iputil.Test.test_get_interface)
   10600s Check that get_interface() returns the right info ...

https://autopkgtest.ubuntu.com/results/autopkgtest-noble/noble/s390x/n/nvme-stas/20231128_021002_94626@/log.gz

Indeed, running the following hangs as well:

from staslib import iputil

iputil.net_if_addrs()

This is an endianness issue that can be fixed by using native byte-ordering when packing and unpacking netlink data structures such as ifaddrmsg.

martin-belanger commented 11 months ago

Good catch. Thanks for the fix.

martin-belanger commented 11 months ago

@ogayot - Salut Olivier. What you found is a critical bug for big-endian systems and a new version of nvme-stas (2.3.1) is required. It looks like you're in the middle of testing nvme-stas. So, maybe I should wait until you've completed your testing before I cut a new release (just in case you find more bugs). Please let me know once you're done and I will release version 2.3.1. Thanks!

ogayot commented 11 months ago

Bonjour @martin-belanger. Thanks for the feedback! I think I won't be doing more testing for now. nvme-stas should be ready to migrate in Ubuntu (and in Debian hopefully) with the various patches applied.

There is one more issue that I have encountered (on some esoteric setups) with the udev test-cases. I am going to file another issue. I am not sure it is a valid use-case or if it is critical enough to fix for 2.3.1.

Thanks, Olivier

martin-belanger commented 11 months ago

@ogayot - Please note that version 2.3.1 has been released.