search

linux-on-ibm-z / dockerfile-examples

A collection of examples to show how Dockerfiles could be created and used on Linux on IBM z Systems.
37 stars 62 forks source link

InfluxDB does not build anymore #17

Open rvdheij opened 3 years ago

rvdheij commented 3 years ago

Trying to build InfluxDB 1.8.2 with --build-arg VERSION=1.8.2 fails because of the explicit reference to a patch that is for v2 specifically. The build with default version appears to hang.

I think you should reconsider the approach to get patches like this from the raw content of another repository, as that makes things rather fragile. If you don't want to contribute patches to fix upstream, then at least package them with your Dockerfile as a single repository.

Even though v1 is end of life, there is value in building the v1 image. The two versions are not compatible and data migration between the two is necessary.

aborkar-ibm commented 3 years ago

Noted. The way currently the dockerfiles are created for each version, passing of VERSION using build arg will not work. You can checkout the specific required version from the history. For now to build 1.8.2 version, you can use https://github.com/linux-on-ibm-z/dockerfile-examples/blob/724bac7302a7c9c8607149f3ccf405b437342787/InfluxDB/Dockerfile