cwsolee
commented
4 years ago We're not accepting PR for our scripts repo but will take a look at your comment to c what is relevant to our deliveries. E.g. we've no plan to add ClefOS support. Our scripts was meant to be used along with our build instruction and match our manual steps, feel free to use these as base and customize to fit your purpose. Even though we're not accepting PR, I've reviewed your comments and want to share our response & what we might consider changing for future. Moved install scripts into one script, thus cutting down on redundant code -- we consider 1 script approach before but it means whenever we change it we've to test all version to make sure there is no regression, it does means that we do have lots of duplicate code with having 1 script for each version, will consider this for future. Made Client install and Service install optional -- possible, will consider this for future version Added a move Tar function for Docker users (Need fixed path to find Tar in multi-stage builds) -- don't quite understand what u mean but the whole script is trying to match our build instruction, it has nothing to do with docker. Allow users to build full Tar or OSS Tar -- We're building OSS Tar only because additional component like x-pack is not open source. Added Support for Clefos, due to that is the closest thing on s390x to Centos -- Not in plan at this moment. Allows users to use one script to install 7.X releases instead of having multiple scripts full of redundant code -- same as 1st comment.
Overhauled the Elasticsearch build scripts. Here are the major changes:
s390xto CentosAll these features benefit the community and potential/existing customers. The changes I made were guided by giving users as close as possible to a 1 to 1 experience as if they were on
x86.Let me know if you have any questions.