search

linux-rdma / opensm

Other
66 stars 36 forks source link

Remove packed when possible #16

Closed nmorey closed 5 years ago

nmorey commented 5 years ago

WIP on issue #15

This removes the packed attribute from all structs that do not need it. All remaining structs are impacted either by a size change or hole inserted for alignment.

hnrose commented 5 years ago

WIP on issue #15

This removes the packed attribute from all structs that do not need it. All remaining structs are impacted either by a size change or hole inserted for alignment.

I visually inspected all struct changes where packing is removed and it looks fine to me. What is next step ? Should I test these changes out ? Are there more to come (and if so, would this patch be modified or would it be a subsequent patch to this) ?

nmorey commented 5 years ago

These changes should be 100% safe. Pahole checked all the struct in 32 and 64 bits and sees no change.

There should probably be more changes but they are tricky. Not sure if they are worth doing

hnrose commented 5 years ago

These changes should be 100% safe. Pahole checked all the struct in 32 and 64 bits and sees no change.

I did some initial testing with this patch and my simple tests worked. I'll merge patch and some regression tests will be run probably over the weekend.

There should probably be more changes but they are tricky. Not sure if they are worth doing

OK

hnrose commented 5 years ago

Manually merged

hnrose commented 5 years ago

Unfortunately some regressions are now failing. I started to investigate these failures. Not sure if this is an issue with the regressions or whether it's caused by this patch. Still investigating...

hnrose commented 5 years ago

It is likely just a regression issue.

hnrose commented 5 years ago

Closing