Add support for registering an opensm plugin as a new routing engine - Githubissues

linux-rdma / opensm

Other

66 stars 36 forks source link

Add support for registering an opensm plugin as a new routing engine #17

Closed cyrilleverrier closed 5 years ago

cyrilleverrier commented 5 years ago

Add new function: osm_opensm_register_routing_engine
Predefined routing engines (minhop, updn, ...) are registered on startup
When registering a new plugin, the provided type is used. If type is OSM_ROUTING_ENGINE_TYPE_UNKNOWN, a new one is generated.
osmeventplugin.c: example of event + routing engine plugin
fix typos: routine engine -> routing engine

Tested with ibsim and the following modifications in opensm.conf:

event_plugin_name osmeventplugin
routing_engine routing_engine_plugin

Linux Kernel Coding style tested with: ./checkpatch.pl --terse --file --no-tree opensm/osm_opensm.c osmeventplugin/src/osmeventplugin.c

checkpatch.pl script file downloaded at https://github.com/torvalds/linux/blob/master/scripts/checkpatch.pl

Signed-off-by: Cyrille Verrier cyrille.verrier@fabriscale.com

vladko1974 commented 5 years ago

Hi,

Could you please elaborate about motivation of the patch in the commit message?

tamirronen commented 5 years ago

Need to add Copyright for each modified file e.g. "Copyright (c) 2013 Mellanox Technologies LTD. All rights reserved." What Copyright to use?

cyrilleverrier commented 5 years ago

Need to add Copyright for each modified file e.g. "Copyright (c) 2013 Mellanox Technologies LTD. All rights reserved." What Copyright to use?

If ok with you, the following line can be used: "Copyright (c) 2019 Fabriscale Technologies AS. All rights reserved."

tamirronen commented 5 years ago

PR merged manually to master

cyrilleverrier commented 5 years ago

@tamirronen Thank you for having merged this PR and all your support