Closed jecavil closed 6 years ago
Should at least reference IBA 1.3 vol 1 rather than 1.2.1
Also, beyond 1.3, there is 2x which allows values 16-31 as follows: If PortInfo:CapabilityMask2.IsLinkWidth2xSupported is set to 1: 16: 2x 17: 1x or 2x 18: 2x or 4x 19: 1x or 2x or 4x 20: 2x or 8x 21: 1x or 2x or 8x 22: 2x or 4x or 8x 23: 1x or 2x or 4x or 8x 24: 2x or 12x 25: 1x or 2x or 12x 26: 2x or 4x or 12x 27: 1x or 2x or 4x or 12x 28: 2x or 8x or 12x 29: 1x or 2x or 8x or 12x 30: 2x or 4x or 8x or 12x 31: 1x or 2x or 4x or 8x or 12x
PR should just include this commit and not the other 2 commits.
I see where IBA 1.2.1 comes from - consistent with force_link_speed*
This commit looks fine. Main things are: should 16-31 be supported and removing other patches previous to the force_link_width one.
Tested and merged
# Force PortInfo:LinkWidthEnabled on switch ports # If 0, don't modify PortInfo:LinkWidthEnabled on switch port # Otherwise, use value for PortInfo:LinkWidthEnabled on switch port # Values are (IB Spec 1.2.1, 14.2.5.6 Table 146 "PortInfo") # 1: 1x # 2: 4x # 3: 1x or 4x # 4: 8x # 5: 1x or 8x # 6: 4x or 8x # 7: 1x or 4x or 8x # 8: 12x # 9: 1x or 12x # 10: 4x or 12x # 11: 1x or 4x or 12x # 12: 8x or 12x # 13: 1x or 8x or 12x # 14: 4x or 8x or 12x # 15: 1x or 4x or 8x or 12x # 16-254 Reserved # Default 255: set to PortInfo:LinkWidthSupported force_link_width 255