linux-rdma / perftest

Infiniband Verbs Performance Tests
Other
592 stars 283 forks source link

perftest: support set flow_label through env variable FLOW_LABEL #224

Closed changchengx closed 1 year ago

changchengx commented 1 year ago
changchengx commented 1 year ago

Follow below steps to build perftest with this PR

git clone https://github.com/linux-rdma/perftest.git
cd perftest
wget https://github.com/linux-rdma/perftest/pull/224.diff
git apply 224.diff
./autogen.sh
mkdir install
./configure --prefix=$PWD/install
make
make install

Follow below steps to run ib_write_lat with this PR

  1. Server
    taskset -c 2 ./install/bin/ib_write_lat -F -s 2 --tclass=106 --ib-dev=mlx5_bond_0 -x 3 -D 60

    Note: add FLOW_LABEL=xxx before taskset to run the command if it needs to specify flow_label value.

  2. Client
    taskset -c 2 ./install/bin/ib_write_lat -F -s 2 --tclass=106 --ib-dev=mlx5_bond_0 -x 3 -D 60 ${server_ip}

    Note: add FLOW_LABEL=xxx before taskset to run the command if it needs to specify flow_label value.

changchengx commented 1 year ago

@HassanKhadour Please help review this PR when you're avaiable.

HassanKhadour commented 1 year ago

Hi @changchengx , thanks for your contribution! Is there any reason why not to add the flow_label as perftest param? also please update the man page and the commit message to include the data in https://github.com/linux-rdma/perftest/pull/224#issue-1853239069

changchengx commented 1 year ago

@HassanKhadour Do you prefer to add flow_label as perftest param instead of using environment variable to set flow_label?

HassanKhadour commented 1 year ago

@changchengx yes it would be the preferred option

changchengx commented 1 year ago

@changchengx yes it would be the preferred option

@HassanKhadour Feedback to you later.

changchengx commented 1 year ago

@changchengx yes it would be the preferred option

@HassanKhadour Feedback to you later.

@HassanKhadour Done

HassanKhadour commented 1 year ago

@changchengx yes it would be the preferred option

@HassanKhadour Feedback to you later.

@HassanKhadour Done

Thanks!, just a small fix, and please add data to the commit message as you did in https://github.com/linux-rdma/perftest/pull/224#issue-1853239069

changchengx commented 1 year ago

@HassanKhadour

  1. used return FAILURE
  2. Added commit msg to explain this PR.
HassanKhadour commented 1 year ago

@changchengx Thanks for your contribution! merged