Closed blochl closed 8 months ago
This may break existing scripts parsing the output and expecting a floating point number. Maybe a warning message would suffice?
This may break existing scripts parsing the output and expecting a floating point number. Maybe a warning message would suffice?
@firasj, Sure. Where would you put the warning message then?
as @firasj said, I think this change is problematic and can damage many automations that parses the output and will cause it to fail.
@HassanKhadour, yes, I agree (sorry if my reply above was misunderstood). I genuinely asked where would you suggest to put this warning message?
The output looks like this now:
---------------------------------------------------------------------------------------
#bytes #iterations BW peak[Gb/sec] BW average[Gb/sec] MsgRate[Mpps] CPU_Util[%]
65536 186641 0.00 195.69 0.373258 4.17
---------------------------------------------------------------------------------------
Can you suggest a proper place? Also what to do in the JSON file? A warning message can't be put there...
@HassanKhadour, @firasj - thanks for your feedback. A warning was added instead.
@blochl Thanks for your contribution! merged
In BW measurements which run, e.g., with a specified duration, BW peak measurement is disabled implicitly, and a peak BW 0 is displayed in the results' summary. This can be confusing to the user, who does not choose to run without peak-bw explicitly, and makes the user assume that something went wrong during the run. To mitigate this, a warning message is displayed now.