linux-rdma / perftest

Infiniband Verbs Performance Tests
Other
592 stars 283 forks source link

Display a warning if BW peak measurement was disabled implicitly #238

Closed blochl closed 8 months ago

blochl commented 9 months ago

In BW measurements which run, e.g., with a specified duration, BW peak measurement is disabled implicitly, and a peak BW 0 is displayed in the results' summary. This can be confusing to the user, who does not choose to run without peak-bw explicitly, and makes the user assume that something went wrong during the run. To mitigate this, a warning message is displayed now.

firasj commented 9 months ago

This may break existing scripts parsing the output and expecting a floating point number. Maybe a warning message would suffice?

blochl commented 9 months ago

This may break existing scripts parsing the output and expecting a floating point number. Maybe a warning message would suffice?

@firasj, Sure. Where would you put the warning message then?

HassanKhadour commented 9 months ago

as @firasj said, I think this change is problematic and can damage many automations that parses the output and will cause it to fail.

blochl commented 8 months ago

@HassanKhadour, yes, I agree (sorry if my reply above was misunderstood). I genuinely asked where would you suggest to put this warning message?

The output looks like this now:

---------------------------------------------------------------------------------------
 #bytes     #iterations    BW peak[Gb/sec]    BW average[Gb/sec]   MsgRate[Mpps]    CPU_Util[%]
 65536      186641           0.00               195.69         0.373258     4.17
---------------------------------------------------------------------------------------

Can you suggest a proper place? Also what to do in the JSON file? A warning message can't be put there...

blochl commented 8 months ago

@HassanKhadour, @firasj - thanks for your feedback. A warning was added instead.

HassanKhadour commented 8 months ago

@blochl Thanks for your contribution! merged