search

linux-speakup / espeakup

a light weight connector for espeak-ng and speakup
GNU General Public License v3.0
32 stars 12 forks source link

switch to meson #30

Closed alex19EP closed 3 years ago

alex19EP commented 3 years ago

use meson instead of make.

justefecation

some comments

I need to tidy up commit history before merge.

sthibaul commented 3 years ago

Note: we really should squash all of this into one commit, the commit series is wip only.

alex19EP commented 3 years ago

Note: we really should squash all of this into one commit, the commit series is wip only.

Yes of course. it's just easier to understand.

williamh commented 3 years ago

I would put the include directory at the same level as the src directory instead of inside it. In README.md, you have "uses a meson". It should read "uses meson". Please avoid automagic dependencies [1]. The best way to do this is, if you have a dependency that is optional, allow the user to control whether it is required or not with a meson option. For example:

systemd = dependency('systemd', required: get_option('systemd'))

and in this case I would make the default false.

[1] https://wiki.gentoo.org/wiki/Project:Quality_Assurance/Automagic_dependencies

alex19EP commented 3 years ago

I would put the include directory at the same level as the src directory instead of inside it.

since there is no public api there i don't think it is a good idea.

In README.md, you have "uses a meson". It should read "uses meson".

will fix.

Please avoid automagic dependencies [1]. The best way to do this is, if you have a dependency that is optional, allow the user to control whether it is required or not with a meson option.

will do.

williamh commented 3 years ago

The other path I would go for is to avoid a src/include directory altogether and put the headers in the src directory since we only build one executable; systemd is an example of a project that puts non-shared header files in the same directory as the sources that use them.

alex19EP commented 3 years ago

The other path I would go for is to avoid a src/include directory altogether and put the headers in the src directory since we only build one executable; systemd is an example of a project that puts non-shared header files in the same directory as the sources that use them.

done that.

alex19EP commented 3 years ago

ok. I think I addressed all feedback.