search

linux-sunxi / libvdpau-sunxi

Experimental VDPAU for Allwinner sunxi SoCs (obsolete, see https://linux-sunxi.org/Sunxi-Cedrus)
https://linux-sunxi.org/Cedrus
166 stars 80 forks source link

Improvements to help with mythtv integration #1

Closed pkendall64 closed 11 years ago

pkendall64 commented 11 years ago

I have been building MythTV frontend to work on a MELE A3700 and I have built it with VDPAU support for the MELE.

I have made the changes in the pull request and MythTV runs, but doesn't display anything yet as I get these printed on the console.

[VDPAU SUNXI] vdp_output_surface_render_bitmap_surface called but unimplemented!
[VDPAU SUNXI] Requested unimplemented picture_structure

Any help would be appreciated.

Thanks, and great job so far!

jemk commented 11 years ago

It's hardly surprising that output doesn't work, as this is still only a proof of concept for decoding. Output is only implemented as far as it was necessary to see decoded picture in mplayer. Any help improving that is greatly appreciated, but there are many things that need to be considered (driver integration, sunxi/mainline kernel …).

Regarding the pull request, i would prefer having proper author information in commits (not "root").

And for completeness, only my personal opinion: The change in handle numbering would be a workaround for "bad" player implementations. VDP_INVALID_HANDLE is 0xffffffff, so 0 should be a valid handle. And for error checking there is returned status, so why check handle too? There even is nothing in specification that says that handles have to have some special value after an error.

pkendall64 commented 11 years ago

I have rewritten the commits with the author corrected.

I agree with you in spirit about the way that MythTV is checking the returned handle being wrong and will create a patch for that project as well.

jemk commented 11 years ago

thanks Handle numbering taken into account at dd56f97042857c9b89cb0d36e722626361d0bb4f.