search

linux-sunxi / libvdpau-sunxi

Experimental VDPAU for Allwinner sunxi SoCs (obsolete, see https://linux-sunxi.org/Sunxi-Cedrus)
https://linux-sunxi.org/Cedrus
166 stars 80 forks source link

Build and optimization #4

Closed edwardoid closed 10 years ago

edwardoid commented 10 years ago

Hi man, I've just fixed build issue and changed non-optimize code. I think it will be great ro merge my changes with your code. You can nontact me in anytime: edward.sarkisyan@gmail.com

jemk commented 10 years ago

Sorry, but I won't merge this, some reasons below:

2719eec: adding CC is ok, but building *.c is a bad idea imho.

https://github.com/edwardoid/libvdpau-sunxi/commit/0c0e860c24bb8e60531ff059bda638179238c335#diff-f79082b271e6258c1250430f7ead6a10L212 and following seriously breaks decoding! You can't skip bits, you have to decode the whole bitstream even if you don't use the data.

i++ -> ++i: um? I don't see any use in this and will never do this. Even the ARM optimization manual uses i++ and recommends to replace it by i-- where possible, but not by ++i.

77fa2a0: libvdpau-sunxi doesn't have to do anything with fbturbo...