linux-surface / iptsd

Userspace daemon for Intel Precise Touch & Stylus
GNU General Public License v2.0
86 stars 39 forks source link

Side button random presses Slim pen 2 #102

Open Haislich opened 1 year ago

Haislich commented 1 year ago

While using the pen sometimes the input is misinterpreted, ad detects the press of the side button. The solution mentioned here seem to work partially work but.

https://user-images.githubusercontent.com/42048782/210048417-f4104b5a-3874-4e07-946f-fed07288ac17.mp4

https://user-images.githubusercontent.com/42048782/210048421-a866fe69-4dc8-48b7-ae4b-f8a32a2df871.mp4

StollD commented 1 year ago

I am assuming that the first video is the behaviour with the proposed solution and the second one is the one without? Posting two videos without any kind of explanation isnt really helpful.

My guess is that the issue is fundamentally the same as #99: The values used in the DFT detection are (educated) guesses, and they might work better on one device than on another. The DFT code also doesn't seem to take noise into account (if that is even a possible issue). We would probably need a calibration tool similar to the one I made for the touchscreen so that people can fine tune the values.

Unfortunately, I can't really offer any helpful advice, since I don't own a device with a DFT stylus, and I am not really familiar with the theory behind that code either.

Haislich commented 1 year ago

I'm sorry, my bad. Both videos are before the suggested solution. After the solution the clicks are so sporadic that are hard to catch on video. Anyway the fine tuning tool might be a great idea, because for example palm rejection is still an hit or miss, the ability to enable/disable touch when the pen is touching the screen might be useful.

makinbacon21 commented 1 year ago

Note that the old suggested soln required a recomp, and that stuff is no longer there. I was able to resolve this using the newer version of the soln--edit /etc/iptsd.conf and set ButtonMinMag to 3000. You can tweak that value from there. Palm rejection I used the calibration tool for, same as touchpad calibration on SLS.