search

linux-surface / kernel

Linux kernel with modifications for Microsoft Surface devices.
Other
124 stars 34 forks source link

Surface Go World Facing Camera Support #109

Closed djrscally closed 3 years ago

djrscally commented 3 years ago

This patchset contains 3 series:

  1. The latest version of the ov8865 driver with updates following feedback from the mailing list
  2. @jwrdegoede's series adding support for the TPS68470's regulator and clock parts, plus detailing the platform info that's needed to make those work for the ov8865
  3. A mini-series that makes fwnode_graph_get_next_endpoint() check fwonde->secondary, which I upstreamed a while ago and the ov8865 driver now relies on.

This will fix the issues folks with Go1/Go2 have been having with the user facing camera and enable the world facing camera for them also.

qzed commented 3 years ago

Thanks! I'll have a look at this tomorrow.

qzed commented 3 years ago

Looks good to me! Tested on my Surface Book 2 and I can't spot any regressions. Thanks again!

Some notes unrelated to the changes: The world-facing camera is still flipped horizontally and the latest libcamera doesn't seem to do proper white-balancing(?) for it (black image except when directly pointing at the sun). User-facing camera works nicely. Both issues are present regardless of these changes here.