search

linux-surface / surface-aggregator-module

Linux ACPI and Platform Drivers for Surface Devices using the Surface Aggregator Module over Surface Serial Hub (Surface Book 2, Surface Pro 2017, Surface Laptop, and Newer)
GNU General Public License v2.0
97 stars 11 forks source link

DTX support on Surface Book 3 #39

Closed qzed closed 3 years ago

qzed commented 4 years ago

Implement support for DTX on Surface Book 3. IRPMon logs for detach/attach can be found in https://github.com/linux-surface/linux-surface/issues/201#issuecomment-635880484.

From an initial look at the logs, the SAM interface on the SB3 seems to be the same. This means that likely only the ACPI device used on the SB2 has been removed. This would also mean that the only changes necessary are: 1) Adding a MODULE_ALIAS to the DTX module, and 2) adding a corresponding entry to the SID MFD cell.

qzed commented 4 years ago

DTX support for the SB3 has been implemented in eeea051bab665eab7aff37ae310b7998ae6b085d (branch feature/sb3-v2) and is confirmed working (https://github.com/linux-surface/linux-surface/issues/201#issuecomment-640824459).

I'll close this issue once this has been merged.

qzed commented 4 years ago

According to https://github.com/linux-surface/surface-aggregator-module/issues/40#issuecomment-644234987, the event enable/disable calls are different than on the SB2. This needs further investigation.

qzed commented 3 years ago

DTX support is now implemented in the cleanup branch. If you want to test this with the DTX daemon, you'll have to build it from the cleanup branch as the user-space interface has changed. I'll update the DTX daemon package in sync with integration into the kernel.

qzed commented 3 years ago

Support is now in master and in the latest linux-surface kernel releases. The DTX daemon has been updated accordingly and new packages are available.