fwupd < 1.4.0 complains about hex version numbers

linux-surface / surface-uefi-firmware

UEFI firmware updates for surface using fwupd. WIP, be careful.

110 stars 9 forks source link

fwupd < 1.4.0 complains about hex version numbers #6

Closed yesrod closed 4 years ago

yesrod commented 4 years ago

In commit afdaf5a68be332c4cce55448e8c4bd3f9ec34560 processing of the hex version number to triplets was removed. However, distros as recent as Ubuntu 20.04 are still shipping versions of fwupd lower than 1.4.0, so it would be nice if that processing still happened.

(I just re-implemented the same thing less elegantly and went to submit a PR before I noticed that the exact same thing had already been removed.)

StollD commented 4 years ago

Ah well. I thought that would get at least backported to the debian based distros.

I'll revert the commit. Thanks for the heads up.

yesrod commented 4 years ago

Thanks, that worked for me, I was able to install an ME firmware update on my Surface Go after that change.