linux-system-roles / .github

Common github actions for the linux-system-roles organization
MIT License
1 stars 8 forks source link

replace action shellcheck.yml with differential_shellcheck.yml #13

Closed nhosoi closed 1 year ago

nhosoi commented 1 year ago
richm commented 1 year ago

Also git rm -f playbooks/templates/.github/workflows/shellcheck.yml

nhosoi commented 1 year ago

Also git rm -f playbooks/templates/.github/workflows/shellcheck.yml

I was wondering about the file. Since we put it in the absent_files, can we expect it will be automatically absent? https://github.com/linux-system-roles/.github/pull/13/files#diff-ee877de6bbd0a00a6b5cad8bdb7ec1f27fbb4d5d96e5e77b27a56fce75562273R12-R14

How about the individual roles which do not have shell scripts? Do we want to do git rm shellcheck.yml and merge it, too?

richm commented 1 year ago

Also git rm -f playbooks/templates/.github/workflows/shellcheck.yml

I was wondering about the file. Since we put it in the absent_files, can we expect it will be automatically absent?

It will be removed from the role repos, but it also should be removed from this .github repo as well.

https://github.com/linux-system-roles/.github/pull/13/files#diff-ee877de6bbd0a00a6b5cad8bdb7ec1f27fbb4d5d96e5e77b27a56fce75562273R12-R14

How about the individual roles which do not have shell scripts? Do we want to do git rm shellcheck.yml and merge it, too?

Yes.

richm commented 1 year ago

@nhosoi please also revert this PR

nhosoi commented 1 year ago

@nhosoi please also revert this PR

Thank you, @richm. I've opened https://github.com/linux-system-roles/.github/pull/18.