linux-system-roles / certificate

Role for managing TLS/SSL certificate issuance and renewal
https://linux-system-roles.github.io/certificate/
MIT License
30 stars 21 forks source link

add weekly-ci action #137

Closed ukulekek closed 1 year ago

ukulekek commented 1 year ago

Signed-off-by: Evgeny Fedin efedin@redhat.com

ukulekek commented 1 year ago

This action will trigger the CI system to test the role every weekend. It will ensure the role didn't break because of dependencies and other factors while being inactively developed. See https://url.corp.redhat.com/1ab3ab1 for more details

rjeffman commented 1 year ago

This will create a pull request that will require manual intervention every week. Isn't there a way that we could run this tests without creating the PR? If not, can, at least, the PR be automatically closed if tests pass?

richm commented 1 year ago

This will create a pull request that will require manual intervention every week.

It should not require any manual intervention.

Isn't there a way that we could run this tests without creating the PR?

Not with the current state of baseos ci.

If not, can, at least, the PR be automatically closed if tests pass?

Yes, but is it a problem if there is a "fake" PR that can be ignored?

rjeffman commented 1 year ago

I don't like it, but it is not a big problem. It'll just pile some PRs.

ukulekek commented 1 year ago

The PR is updated to the latest version @richm