search

linux-system-roles / certificate

Role for managing TLS/SSL certificate issuance and renewal
https://linux-system-roles.github.io/certificate/
MIT License
30 stars 21 forks source link

ansible-lint 6.x fixes #143

Closed richm closed 1 year ago

richm commented 1 year ago

Use true/false instead of yes/no Fix spacing in braces/brackets All tasks must be named Documents should begin with --- Other cleanup

richm commented 1 year ago

[citest]

richm commented 1 year ago

lgtm.

@richm what was failing due to the use of "yes/no"? IIRC, ansible-freeipa pass ansible-test with "yes/no".

https://ansible-lint.readthedocs.io/rules/yaml/ - yaml[truthy] - see also https://github.com/redhat-cop/automation-good-practices/tree/main/coding_style#yaml-and-jinja2-syntax Use true and false for boolean values in playbooks

Not sure why you don't see this in ansible-freeipa - perhaps you are suppressing it in .ansible-lint or .yamllint.yml or elsewhere?

richm commented 1 year ago

[citest]

rjeffman commented 1 year ago

lgtm. @richm what was failing due to the use of "yes/no"? IIRC, ansible-freeipa pass ansible-test with "yes/no".

https://ansible-lint.readthedocs.io/rules/yaml/ - yaml[truthy] - see also https://github.com/redhat-cop/automation-good-practices/tree/main/coding_style#yaml-and-jinja2-syntax Use true and false for boolean values in playbooks

Not sure why you don't see this in ansible-freeipa - perhaps you are suppressing it in .ansible-lint or .yamllint.yml or elsewhere?

Found it. On .yamllint we have:

  truthy:
    allowed-values: ["yes", "no", "true", "false", "True", "False"]

Thank you for the pointers.