linux-system-roles / certificate

Role for managing TLS/SSL certificate issuance and renewal
https://linux-system-roles.github.io/certificate/
MIT License
30 stars 21 forks source link

ci: Remove certreader dependency #180

Closed rjeffman closed 1 year ago

rjeffman commented 1 year ago

certreader, which provides certreader2json is not activelly maintained and is not compiling in all platforms supported by the certificate linux system role.

This patch removes its dependency by providing a similar certificate parser.

richm commented 1 year ago

tox -e qemu-ansible-core-2.15 -- --image-name rhel-8-9 --log-level debug -- tests/tests_basic_ipa.yml output

TASK [Ensure packages are updated] *********************************************
task path: /home/rmeggins/linux-system-roles/certificate/tests/tasks/assert_certificate_parameters.yml:10
Wednesday 05 July 2023  11:10:30 -0600 (0:00:01.178)       0:09:46.614 ******** 
fatal: [/home/rmeggins/.cache/linux-system-roles/rhel-8-9.qcow2]: FAILED! => {
    "changed": false,
    "cmd": [
        "/tmp/certificate-tests-venv/bin/pip3",
        "install",
        "-U",
        "pip",
        "cryptography",
        "pyasn1"
    ]
}

MSG:

stdout: Collecting pip
  Downloading https://files.pythonhosted.org/packages/a4/6d/6463d49a933f547439d6b5b98b46af8742cc03ae83543e4d7688c2420f8b/pip-21.3.1-py3-none-any.whl (1.7MB)
Collecting cryptography
  Downloading https://files.pythonhosted.org/packages/f7/80/04cc7637238b78f8e7354900817135c5a23cf66dfb3f3a216c6d630d6833/cryptography-40.0.2.tar.gz (625kB)
    Complete output from command python setup.py egg_info:

            =============================DEBUG ASSISTANCE==========================
            If you are seeing an error here please try the following to
            successfully install cryptography:

            Upgrade to the latest pip and try again. This will fix errors for most
            users. See: https://pip.pypa.io/en/stable/installing/#upgrading-pip
            =============================DEBUG ASSISTANCE==========================

    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-x87z71ld/cryptography/setup.py", line 18, in <module>
        from setuptools_rust import RustExtension
    ModuleNotFoundError: No module named 'setuptools_rust'

    ----------------------------------------

:stderr: Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-x87z71ld/cryptography/
You are using pip version 9.0.3, however version 23.1.2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
rjeffman commented 1 year ago

[citest]

richm commented 1 year ago

ignore the plugin scan failure - it doesn't know how to process plugins provided in tests/library

richm commented 1 year ago

lgtm - just waiting for the test results

rjeffman commented 1 year ago

[citest]

rjeffman commented 1 year ago

[citest]