Closed richm closed 9 months ago
Attention: 20 lines
in your changes are missing coverage. Please review.
Comparison is base (
4f50fa1
) 0.00% compared to head (ee5e5b7
) 32.95%.
Files | Patch % | Lines |
---|---|---|
module_utils/certificate_lsr/providers/base.py | 79.62% | 11 Missing :warning: |
...dule_utils/certificate_lsr/providers/certmonger.py | 64.00% | 9 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
[citest]
[citest]
centos 7 and 9 failures are baseos ci issues - the tests pass on those platforms locally
The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The new ansible-lint has several checks related to ansible-test and the ignore files. Many of our ignore settings are not allowed any more and are required to be fixed or addressed in the Ansible preferred way.
The python imports have to be wrapped in a try/except ImportError, and where possible, an error must be returned from the module explaining what was not able to be imported.
The result of this is that the .sanity files can be reduced to the bare minimum which will greatly reduce the maintenance burden of those files, make it easier to support newer versions of Ansible, and make it easier to import the system roles collection into Galaxy and Automation Hub.
distutils.version
is deprecated, and it is a hard error in python 3.12 Instead, usepackaging.version
- unfortunately, this means having to add a dependency onpython3-packaging
on platforms that support it - notably, there is no python-packaging available on EL7, so fall back to usingdistutils.version
there.The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test.
Role developers can run this locally using
tox -e collection,ansible-lint-collection
See https://github.com/linux-system-roles/tox-lsr/pull/125Add
---
doc start to .markdownlint.yamlSigned-off-by: Rich Megginson rmeggins@redhat.com