search

linux-system-roles / certificate

Role for managing TLS/SSL certificate issuance and renewal
https://linux-system-roles.github.io/certificate/
MIT License
30 stars 21 forks source link

ci: Add support for SUSE ALP-Dolomite #215

Closed HVSharma12 closed 8 months ago

HVSharma12 commented 8 months ago

Enhancement: Add support for SUSE ALP-Dolomite in the certificate Ansible role.

Reason: This enhancement aims to introduce compatibility by adjusting file paths, package dependencies

Result: Updated the certificate role for SUSE ALP-Dolomite

Issue Tracker Tickets (Jira or BZ if any):na

spetrosi commented 8 months ago

Did you test this against Suse and can you confirm that this change is sufficient?

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b77c7fd) 32.95% compared to head (b87609b) 32.95%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #215 +/- ## ======================================= Coverage 32.95% 32.95% ======================================= Files 3 3 Lines 613 613 Branches 128 128 ======================================= Hits 202 202 Misses 411 411 ``` | [Flag](https://app.codecov.io/gh/linux-system-roles/certificate/pull/215/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/linux-system-roles/certificate/pull/215/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | `32.95% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

HVSharma12 commented 8 months ago

@spetrosi yes the role works as expected on Suse ALP-Dolomite tested all the mentioned examples also using certificate_test_mode=true&certificate_test_remove_files=true.

richm commented 8 months ago

@HVSharma12 the files in .ostree - I guess ALP Dolomite is similar to ostree? You build a read-only image using packages specified in files in the .ostree directory? For example, for RedHat family, we use osbuild to build ostree images e.g. https://github.com/linux-system-roles/tox-lsr#building-ostree-images - is ALP Dolomite similar?

HVSharma12 commented 8 months ago

@richm ALP Dolomite and OSTree have different approaches. While OSTree involves building read-only images with predefined packages (like using .ostree directory in RedHat systems), ALP Dolomite centers around atomic, transactional updates, creating a new snapshot to apply the changes such as package installs you need to reboot the host, not necessarily on building images with a set package list as in OSTree. - although I am looking into options for them to be managed similarly for linux-system-roles.